Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Search] Search Playground - shared rendering (#201302) #203243

Merged
merged 1 commit into from
Dec 6, 2024
Merged

[8.x] [Search] Search Playground - shared rendering (#201302) #203243

merged 1 commit into from
Dec 6, 2024

Conversation

TattdCodeMonkey
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@TattdCodeMonkey
[Search] Search Playground - shared rendering (elastic#201302)
18e8a06 
(cherry picked from commit 434eaa7)

# Conflicts:
#	packages/deeplinks/search/constants.ts
#	packages/deeplinks/search/deep_links.ts
@TattdCodeMonkey TattdCodeMonkey enabled auto-merge (squash) December 6, 2024 15:14
@TattdCodeMonkey TattdCodeMonkey mentioned this pull request Dec 6, 2024
Merged
5 tasks
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2325 2322 -3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/deeplinks-search 21 22 +1
searchNavigation 21 22 +1
searchPlayground 16 13 -3
total -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB -1.8KB
searchPlayground 168.0KB 162.8KB -5.3KB
total -7.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
searchNavigation 0 1 +1
searchPlayground 1 0 -1
total -0

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
enterpriseSearch 54.9KB 54.3KB -636.0B
searchNavigation 4.1KB 5.0KB +954.0B
searchPlayground 7.2KB 7.0KB -225.0B
total +93.0B
Unknown metric groups

API count

id before after diff
@kbn/deeplinks-search 21 22 +1
searchNavigation 21 22 +1
searchPlayground 22 13 -9
total -7

async chunk count

id before after diff
searchPlayground 6 2 -4

ESLint disabled line counts

id before after diff
searchPlayground 4 5 +1

Total ESLint disabled count

id before after diff
searchPlayground 4 5 +1

@TattdCodeMonkey TattdCodeMonkey merged commit 4dd3c9e into elastic:8.x Dec 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemcelroy joemcelroy joemcelroy approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TattdCodeMonkey @elasticmachine @joemcelroy